Lint Generator: No longer fix violations after invocation #1174
+0
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevepolitodesign
force-pushed
the
suspenders-3-0-0-lint-follow-up
branch
from
f9f5246
to
20f987a
Compare
stevepolitodesign
added a commit
that referenced
this pull request
Mar 25, 2024
stevepolitodesign
force-pushed
the
suspenders-3-0-0-lint-follow-up
branch
from
20f987a
to
02b2977
Compare
Supports #1152 We found that we needed to run this generator last in `suspenders:install:web` to ensure any potential violation was resolved. Instead, we'll just make that the responsibility of `suspenders:install:web`.
stevepolitodesign
force-pushed
the
suspenders-3-0-0-lint-follow-up
branch
from
02b2977
to
ec03d1a
Compare
stevepolitodesign
added a commit
that referenced
this pull request
May 10, 2024
stevepolitodesign
added a commit
that referenced
this pull request
May 10, 2024
Supports #1152 We found that we needed to run this generator last in `suspenders:install:web` to ensure any potential violation was resolved. Instead, we'll just make that the responsibility of `suspenders:install:web`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports #1152
We found that we needed to run this generator last in
suspenders:install:webto ensure any potential violation was resolved.Instead, we'll just make that the responsibility of
suspenders:install:web.